Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error occurs in a ODBC call, we were only producing generic error messages about what we we're trying to do.
With this patch we now also include information about the error provided by the ODBC driver.
This is to support https://app.clubhouse.io/cartoteam/story/80914/improve-error-messages-while-importing
For example, if a SQL query executed (via
sql_quey
in IMPORT FOREIGN SCHEMA) was syntactically incorrect, we had:With the extension compiled with debug information and debug messages on we had some additional information, but not as part of the error message:
Now we have the same information in the DEBUG log appendend to the error message:
This will allow for better error messages in the CARTO Import API: see https://app.clubhouse.io/cartoteam/story/80914/improve-error-messages-while-importing